[
https://issues.apache.org/jira/browse/PIG-4350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14236074#comment-14236074
]
Rohini Palaniswamy commented on PIG-4350:
-----------------------------------------
Few comments:
- Instead of increasing memory to 4G for running tests, it would be nice to
figure out the root cause and fix it.
- TestLoadStoreFuncLifeCycle.java
It would be good to see if we can reduce the instantiation. In case of
hcat and hbase, since they connect to the server it is costly.
- TestMockStorage.testBadUsage2
I think we should fix this one as well in Tez.
- TestLocationInPhysicalPlan.java
Current fix is fine. But need to create a new jira to fix
getAliasLocation also specify C: (combiner aliases) in Tez.
- TestForEachNestedPlanLocal.java
List<Tuple> expectedResults = Util.getTuplesFromConstantTupleStrings(new
String[] {"(5L)", "(5L)", "(3L)" });
- TestMacroExpansion.java
- Why do we have to change "B = distinct A partition by
org.apache.pig.Identity; " to "B = distinct A partition by
org.apache.pig.test.utils.SimpleCustomPartitioner; ?
- startsWith("TEZ") condition not required. String mode =
Util.getLocalTestMode().toString();
- test/org/apache/pig/test/Util.java
Need to remove import org.apache.hadoop.hive.common.FileUtils;
Since this is a big patch, we can do Assume.assumeTrue("Skip this test for
TEZ", ....); for tests that require more work and do them in a separate jira
and get the rest checked in as part of this jira.
> Port local mode tests to Tez - part2
> ------------------------------------
>
> Key: PIG-4350
> URL: https://issues.apache.org/jira/browse/PIG-4350
> Project: Pig
> Issue Type: Sub-task
> Components: tez
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.15.0
>
> Attachments: PIG-4350-1.patch, PIG-4350-2.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
