[ 
https://issues.apache.org/jira/browse/PIG-4461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14367481#comment-14367481
 ] 

Daniel Dai commented on PIG-4461:
---------------------------------

LGTM. [~rohini], this patch will do a sort on the cached benchmark. This is to 
address the behavior difference between sort on Unix/Windows. Windows sort file 
differently than Linux, so we cannot compare Windoes test result with benchmark 
file collected under Unix directly. This will increase the total runtime by a 
small margin. Are you Ok with it or you want a flag to enable by demand?

> Use benchmarks for Windows Pig e2e tests
> ----------------------------------------
>
>                 Key: PIG-4461
>                 URL: https://issues.apache.org/jira/browse/PIG-4461
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.14.1
>            Reporter: Namit Maheshwari
>            Assignee: Namit Maheshwari
>            Priority: Critical
>         Attachments: PIG-4461.patch
>
>
> Use benchmarks for Windows Pig e2e tests. Currently in the Pig system test 
> for windows, we do not use benchmarks. Due to this, each test run twice to 
> verify if its a pass. Using benchmark will save a lot of time, in the windows 
> run.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to