[
https://issues.apache.org/jira/browse/PIG-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376353#comment-14376353
]
Anthony Hsu commented on PIG-4475:
----------------------------------
Looks good. One small comment: The indentation in this block looks inconsistent:
{code}
@@ -107,6 +112,13 @@ public final class AvroMapWrapper implements
Map<CharSequence, Object> {
@Override
public Set<CharSequence> keySet() {
+ if (isUtf8key) {
+ final Set<CharSequence> keySet = new HashSet<CharSequence>();
+ for (CharSequence cs : innerMap.keySet()) {
+ keySet.add(cs.toString());
+ }
+ return keySet;
+ }
return innerMap.keySet();
}
{code}
I see both 2 and 4 space indentation. I think we should stick with 2, since the
rest of the files seems to use that.
> Keys in AvroMapWrapper are not proper Pig types
> -----------------------------------------------
>
> Key: PIG-4475
> URL: https://issues.apache.org/jira/browse/PIG-4475
> Project: Pig
> Issue Type: Bug
> Reporter: Ratandeep Ratti
> Assignee: Ratandeep Ratti
> Fix For: 0.15.0
>
> Attachments: PIG-4475.patch
>
>
> AvroMapWrapper could contain utf8 keys, which are not supported by Pig. Pig
> expects keys to be of type String.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
