[ 
https://issues.apache.org/jira/browse/PIG-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Dai updated PIG-4496:
----------------------------
    Attachment: PIG-4496-2.patch

I cannot figure out why we set innerBsStream to null before, checking the use 
cases of CBZip2InputStream, apparently we shall close it instead of setting it 
to null. +1 for the patch, the only thing is missing Apache license header in 
the new file, I added it in PIG-4496-2.patch.

> Fix CBZip2InputStream to close underlying stream
> ------------------------------------------------
>
>                 Key: PIG-4496
>                 URL: https://issues.apache.org/jira/browse/PIG-4496
>             Project: Pig
>          Issue Type: Bug
>          Components: tools
>    Affects Versions: 0.12.0, 0.15.0
>            Reporter: Peter Slawski
>            Assignee: Peter Slawski
>             Fix For: 0.15.0
>
>         Attachments: PIG-4496-2.patch, PIG-4496.1.patch
>
>
> CBZip2InputStream doesn't close the underlying FSDataInputStream when itself 
> is closed. However, users such as BZip2LineRecordReader and XMLLoader assume 
> CBZip2InputStream will do so. This leads to leaking resources and possible 
> failure in reading the next split depending on the FileSystem implementation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to