[
https://issues.apache.org/jira/browse/PIG-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616338#comment-14616338
]
liyunzhang_intel commented on PIG-4611:
---------------------------------------
[~mohitsabharwal]:
I can not make HBaseStorage change conditional on execution engine because I
can not get the instance of PigContext in HBaseStorage, and although
org.apache.pig.impl.PigContext#getExecType exists, it is a non-static method.
in PIG-4611_2.patch: the change to HBaseStorage is:
before:
{code}
String defaultCaster =
UDFContext.getUDFContext().getClientSystemProps().getProperty(CASTER_PROPERTY,
STRING_CASTER);
{code}
After:
{code}
String defaultCaster = UDFContext.getUDFContext().getClientSystemProps() !=
null ?
UDFContext.getUDFContext().getClientSystemProps().getProperty(CASTER_PROPERTY,
STRING_CASTER) : STRING_CASTER;
{code}
I don't think it changes previous code logic and i only verify
UDFContext.getUDFContext().getClientSystemProps() is null or not before
UDFContext.getUDFContext().getClientSystemProps().getProperty(CASTER_PROPERTY,
STRING_CASTER) is used.
> Fix remaining unit test failures about "TestHBaseStorage"
> ---------------------------------------------------------
>
> Key: PIG-4611
> URL: https://issues.apache.org/jira/browse/PIG-4611
> Project: Pig
> Issue Type: Sub-task
> Components: spark
> Reporter: liyunzhang_intel
> Assignee: liyunzhang_intel
> Fix For: spark-branch
>
> Attachments: PIG-4611.patch, PIG-4611_2.patch
>
>
> In https://builds.apache.org/job/Pig-spark/lastCompletedBuild/testReport/, it
> shows following unit test failures about TestHBaseStorage:
> org.apache.pig.test.TestHBaseStorage.testStoreToHBase_1_with_delete
> org.apache.pig.test.TestHBaseStorage.testLoadWithProjection_1
> org.apache.pig.test.TestHBaseStorage.testLoadWithProjection_2
> org.apache.pig.test.TestHBaseStorage.testStoreToHBase_2_with_projection
> org.apache.pig.test.TestHBaseStorage.testCollectedGroup
> org.apache.pig.test.TestHBaseStorage.testHeterogeneousScans
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
