[ 
https://issues.apache.org/jira/browse/PIG-4639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14662005#comment-14662005
 ] 

Rohini Palaniswamy commented on PIG-4639:
-----------------------------------------

We can go with 1 and put a copy of your code in Pig code base if it is not too 
much and when it is integrated into another Apache project like 
https://commons.apache.org/ we can remove the code and refer to that maven 
dependency. But if there is a lot of code, we can leave it at what it is (maven 
dependency) for now.  I would not want to revert the patch when it is a very 
useful feature. 

I would recommend checking with Apache Commons folks to see if your parser can 
be made as part of it. That seems to be a good fit for me instead of thinking 
of a new Apache project which is too much of a hassle for a smaller project.

> Add better parser for Apache HTTPD access log.
> ----------------------------------------------
>
>                 Key: PIG-4639
>                 URL: https://issues.apache.org/jira/browse/PIG-4639
>             Project: Pig
>          Issue Type: New Feature
>          Components: piggybank
>    Affects Versions: 0.15.0
>            Reporter: Niels Basjes
>            Assignee: Niels Basjes
>             Fix For: 0.16.0
>
>         Attachments: PIG-4639-20150723-classnotfound.patch, 
> PIG-4639-20150725.patch, PIG-4639-20150805-1247.patch
>
>
> Currently there are two parsers for Apache HTTPD acces log files in piggybank 
> that only allow parsing the 'combined' and 'common' logformats. These two 
> also only parse the 'basics'.
> This is proposed patch to add the existing 
> https://github.com/nielsbasjes/logparser (Apache 2.0 license) as an 'out of 
> the box' parser to piggybank. 
> This parser parses the logfile using the LogFormat specification used to 
> writte it. Almost all LogFormat specifiers are supported and as such adds 
> easy parsing capabilities for (almost) all custom logformats used in 
> production scenarios. 
> This parser also goes much deeper in the sense that it allows extracting 
> things like the value of a cookie or the value of a  query string parameter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to