----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40692/#review108939 -----------------------------------------------------------
Thanks. Is this the complete patch? I don't see any Spark specific changes here. What is the point of adding addSettingsToConf() to base class if we are not implementing it in this patch ? Does Tez ILLUSTRATE work ? src/org/apache/pig/tools/pigstats/mapreduce/MRScriptState.java (line 70) <https://reviews.apache.org/r/40692/#comment168396> import org.apache.pig.impl.plan.Operator instead of using namespance. src/org/apache/pig/tools/pigstats/mapreduce/MRScriptState.java (line 72) <https://reviews.apache.org/r/40692/#comment168394> remove line src/org/apache/pig/tools/pigstats/mapreduce/MRScriptState.java (lines 75 - 76) <https://reviews.apache.org/r/40692/#comment168393> remove extra lines - Mohit Sabharwal On Nov. 25, 2015, 4:59 a.m., Zulfi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40692/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2015, 4:59 a.m.) > > > Review request for pig. > > > Repository: pig-git > > > Description > ------- > > PIG-4621: Enable Illustrate in spark > > > Diffs > ----- > > > src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/JobControlCompiler.java > 88e3d5b > src/org/apache/pig/tools/pigstats/ScriptState.java bf17490 > src/org/apache/pig/tools/pigstats/mapreduce/MRScriptState.java 1aca7d8 > src/org/apache/pig/tools/pigstats/spark/SparkScriptState.java ccb1c9b > src/org/apache/pig/tools/pigstats/tez/TezScriptState.java d88130a > > Diff: https://reviews.apache.org/r/40692/diff/ > > > Testing > ------- > > Testing done over grunt shell. > > > Thanks, > > Zulfi > >
