[
https://issues.apache.org/jira/browse/PIG-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067621#comment-15067621
]
Kengo Seki commented on PIG-4763:
---------------------------------
Thanks for the comment, [~rohini]. I understood that the root directory is used
as the input and output directory if the 7th (hdfs_root) and 8th
(pigmix_output) parameters are not specified. But if they are optional,
wouldn't it be better to set default values just like "parallel" or other
optional parameters to suppress warnings? In addition, the following code seems
to assume that pigmixoutput is always set. Shouldn't it be skipped?
{code}
41 print STDERR "Removing output dir $pigmixoutput \n";
42 $cmd = "$hadoopbin fs -rmr $pigmixoutput";
43 print STDERR "Going to run $cmd\n";
44 print STDERR `$cmd 2>&1`;
{code}
Sorry if I misunderstand something.
> Insufficient check for the number of arguments in runpigmix.pl
> --------------------------------------------------------------
>
> Key: PIG-4763
> URL: https://issues.apache.org/jira/browse/PIG-4763
> Project: Pig
> Issue Type: Bug
> Reporter: Kengo Seki
> Assignee: Kengo Seki
> Priority: Trivial
> Attachments: PIG-4763.1.patch
>
>
> runpigmix.pl first checks the number of arguments as follows:
> {code}
> 3 if(scalar(@ARGV) < 6 )
> 4 {
> 5 print STDERR "Usage: $0 <pig_home> <pig_bin> <pigmix_jar>
> <hadoop_home> <hadoop_bin> <pig mix scripts dir> <hdfs_root> <pigmix_output>
> [parallel] [numruns] [runmapreduce] [cleanup_after_test]\n";
> 6 exit(-1);
> 7 }
> {code}
> but the number of the required parameters is 8, so this check seems
> insufficient.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
