[
https://issues.apache.org/jira/browse/PIG-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15068400#comment-15068400
]
Rohini Palaniswamy edited comment on PIG-4763 at 12/22/15 5:05 PM:
-------------------------------------------------------------------
bq. But if they are optional, wouldn't it be better to set default values just
like "parallel" or other optional parameters to suppress warnings?
Agree with that. Looks like it will cause warnings or errors if the 7th and
8th one are not set. Can you change the patch to add default values based on
the ones we usually specify in pigmix build.xml ? We can change to say 8
arguments are mandatory too, but it is easier for the users if they have to
specify less arguments as most of the time defaults are good.
was (Author: rohini):
bq. But if they are optional, wouldn't it be better to set default values just
like "parallel" or other optional parameters to suppress warnings?
Agree with that. Looks like it will cause warnings or errors if the 7th and
8th one are not set. Can you change the patch to add default values?
> Insufficient check for the number of arguments in runpigmix.pl
> --------------------------------------------------------------
>
> Key: PIG-4763
> URL: https://issues.apache.org/jira/browse/PIG-4763
> Project: Pig
> Issue Type: Bug
> Reporter: Kengo Seki
> Assignee: Kengo Seki
> Priority: Trivial
> Attachments: PIG-4763.1.patch
>
>
> runpigmix.pl first checks the number of arguments as follows:
> {code}
> 3 if(scalar(@ARGV) < 6 )
> 4 {
> 5 print STDERR "Usage: $0 <pig_home> <pig_bin> <pigmix_jar>
> <hadoop_home> <hadoop_bin> <pig mix scripts dir> <hdfs_root> <pigmix_output>
> [parallel] [numruns] [runmapreduce] [cleanup_after_test]\n";
> 6 exit(-1);
> 7 }
> {code}
> but the number of the required parameters is 8, so this check seems
> insufficient.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
