-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43571/
-----------------------------------------------------------

(Updated March 1, 2016, 4:51 a.m.)


Review request for pig, Xianda Ke, Mohit Sabharwal, Pallavi Rao, and Xuefu 
Zhang.


Changes
-------

The patch modifies the PigSplit. PigSplit extends FileSplit do not extend 
InputSplit. I explain the detail reason in the jira 
page(https://issues.apache.org/jira/browse/PIG-4788).  Hope more pig developers 
join in the discussion.


Bugs: PIG-4788
    https://issues.apache.org/jira/browse/PIG-4788


Repository: pig-git


Description (updated)
-------

I explained more detailed about the modification on jira page.
In PIG-4788.patch:
changes are
1. PigSplit extends FileSplit not InputSplit
2. add try catch to PigSplit#getLocations(), PigSplit#getLength()
3.add PigSplit#getPath(). PigSplit#getPath() will be called in 
NewTrackingRecordReader.


Diffs
-----

  
src/org/apache/pig/backend/hadoop/executionengine/mapReduceLayer/PigSplit.java 
92c6bd6 
  src/org/apache/pig/builtin/mock/Storage.java afc1d29 

Diff: https://reviews.apache.org/r/43571/diff/


Testing
-------

After test, no new unit tests are imported and unit test failures about 
TestOrcStoragePushdown will be fixed.


Thanks,

kelly zhang

Reply via email to