[
https://issues.apache.org/jira/browse/PIG-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214322#comment-15214322
]
Koji Noguchi commented on PIG-4851:
-----------------------------------
Thanks [~rohini], looking good. Most of the test changes are reverting
pig-3123.
I see one new test case for covering one user's case of having custom loader
extending PigStorage.
Can you also add a test case I described on this jira using
{{org.apache.pig.piggybank.storage.CSVLoader}} or alike?
As I mentioned, breaking user's custom loader that was extending PigStorage was
one but more critical issue was null not padded for non-PigStorage loaders.
> Null not padded when input has less fields than declared schema for some
> loader
> -------------------------------------------------------------------------------
>
> Key: PIG-4851
> URL: https://issues.apache.org/jira/browse/PIG-4851
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.12.1, 0.13.0, 0.14.0, 0.15.0
> Reporter: Koji Noguchi
> Assignee: Koji Noguchi
> Attachments: PIG-4851-1.patch
>
>
> {code:title=test.pig}
> A = load 'input.txt' using org.apache.pig.piggybank.storage.CSVLoader() as
> (field1, field2);
> dump A;
> {code}
> {code:title=input.txt}
> a
> b,
> c,d
> ,e
> f
> {code}
> {code:title=expected output by pig-0.11}
> (a,)
> (b,)
> (c,d)
> (,e)
> (f,)
> {code}
> {code:title=incorrect output by trunk and probably from 0.12}
> (a)
> (b)
> (c,d)
> (,e)
> (f)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
