[ 
https://issues.apache.org/jira/browse/PIG-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290173#comment-15290173
 ] 

Rohini Palaniswamy commented on PIG-4714:
-----------------------------------------

bq. With the checking of YarnConfiguration.TIMELINE_SERVICE_ENABLED first, can 
we turn on ATS  by default
    Yes.

{code}
if (Boolean.parseBoolean(pigContext.getProperties()
+                .getProperty(PigConfiguration.ENABLE_ATS))) {
+            if (!Boolean.parseBoolean(pigContext.getProperties()
+                    
.getProperty("yarn.timeline-service.generic-application-history.enabled"))) {
{code}

should be 

{code}
if (Boolean.parseBoolean(pigContext.getProperties()
+                .getProperty(PigConfiguration.ENABLE_ATS, "true"))) {
+            if (!Boolean.parseBoolean(pigContext.getProperties()
+                    .getProperty("yarn.timeline-service.enabled", "false"))) {
{code}

ie. Add defaults in case it is null and yarn.timeline-service.enabled instead 
of yarn.timeline-service.generic-application-history.enabled.  Also the whole 
code including setting hdfs context should be within the second if block of 
timeline server check.

> Improve logging across multiple components with callerId
> --------------------------------------------------------
>
>                 Key: PIG-4714
>                 URL: https://issues.apache.org/jira/browse/PIG-4714
>             Project: Pig
>          Issue Type: Improvement
>          Components: impl
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.16.0
>
>         Attachments: PIG-4714-1.patch, PIG-4714-2.patch, PIG-4714-3.patch
>
>
> The idea is to add callerId to every component, so we can track the chain of 
> application which cause the underlining operation. A typical chain is 
> Oozie->Pig->Tez->Hdfs. With proper callerId logging, we can trace Hdfs 
> operation back to Oozie workflow which triggers it.
> The protocol we decided is every component log its immediate callerId. 
> For Pig, this includes passing Pig script ID to underlining components as 
> callerId using component specific API, log callerId of Pig and store it on 
> ATS. More specific, it includes:
> 1. Generate a CallerId for each Pig script, pass it to 
> Hdfs/Yarn/MapReduce/Tez which Pig invokes
> 2. Pig caller passes "pig.log.trace.id" to Pig, Pig will publish it to ATS



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to