[
https://issues.apache.org/jira/browse/PIG-4967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412884#comment-15412884
]
Xiang Li edited comment on PIG-4967 at 8/9/16 5:07 AM:
-------------------------------------------------------
Hi Daniel, thanks for the comments!
1. Could you please elaborate more on "decompose ControlledJob"?
Do you mean that we should do some checkings before calling line 182 in
PigJobControl as follow:
{code}
log.debug("Checking state of job "+j);
{code}
2. When null is detected, do you think I can throw an Exception(May be
IOException?) here, or I just log a waring, and give up logging in line 182 and
make Pig continue. I prefer the latter one, as line 182 is only to write a log
for debug, we should not stop Pig running if the logging has something wrong?
Does it make sense to you?
was (Author: water):
Hi Daniel, thanks for the comments!
1. Could you please elaborate more on "decompose ControlledJob"?
Do you mean that we should do some checkings before calling line 182 in
PigJobControl as follow:
{code}
log.debug("Checking state of job "+j);
{code}
2. When null is detected, do you think I can throw an Exception(May be
IOException?) here, or I just log a waring, and give up logging in 182 and make
Pig continue. I prefer the latter one, as line 182 is only to write a log for
debug, we should not stop Pig running if the logging has something wrong? Does
it make sense to you?
> NPE in PigJobControl.run() when job status is null
> --------------------------------------------------
>
> Key: PIG-4967
> URL: https://issues.apache.org/jira/browse/PIG-4967
> Project: Pig
> Issue Type: Bug
> Reporter: Xiang Li
> Assignee: Xiang Li
> Priority: Critical
>
> {code}
> [JobControl] ERROR org.apache.pig.backend.hadoop23.PigJobControl - Error
> while trying to run jobs.
> java.lang.NullPointerException
> at org.apache.hadoop.mapreduce.Job.getJobName(Job.java:426)
> at
> org.apache.hadoop.mapreduce.lib.jobcontrol.ControlledJob.toString(ControlledJob.java:93)
> at java.lang.String.valueOf(String.java:2982)
> at java.lang.StringBuilder.append(StringBuilder.java:131)
> at
> org.apache.pig.backend.hadoop23.PigJobControl.run(PigJobControl.java:182)
> at java.lang.Thread.run(Thread.java:745)
> at
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.MapReduceLauncher$1.run(MapReduceLauncher.java:276)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
