[
https://issues.apache.org/jira/browse/PIG-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15417387#comment-15417387
]
Artem Ervits commented on PIG-1183:
-----------------------------------
[~daijy] I looked at these small items and they no longer hold true.
getConfiguration() is already refactored to correct spelling.
ivy/pig.pom file is missing from the ivy directory
there is no longer a class called
org.apache.pig.backend.executionengine.PigSlice.java in that source directory
> Minor nits on pig trunk code
> ----------------------------
>
> Key: PIG-1183
> URL: https://issues.apache.org/jira/browse/PIG-1183
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.6.0
> Reporter: Rekha
> Priority: Minor
> Labels: newbie
>
> Found some minor nits on pig trunk codebase, assigning it to myself.Keeping
> it open to add few more and close it.
> org.apache.pig.backend.executionengine.ExecJob.java
> Line 78: getContiguration() - should it not be getConfiguration() ?
> ivy/pig.pom
> Line 47: </exclusions> - Missing ?
> A general observation on usage of magic numbers, for eg:
> org.apache.pig.backend.executionengine.PigSlice.java
> Line199: magic number -int errCode = 2094; - can be better framed as new
> ExecException(msg, UNABLE_TO_DESERIALIZE, PigException.BUG, cnfe) where
> UNABLE_TO_DESERIALIZE is defined as enum constant
> UNABLE_TO_DESERIALIZE = 2094.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
