[ 
https://issues.apache.org/jira/browse/PIG-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15503087#comment-15503087
 ] 

Adam Szita commented on PIG-4815:
---------------------------------

Thanks for taking a look on this [~kellyzly]
I've published a review request for this: https://reviews.apache.org/r/52026/
Review points 1,2,3,4.1 addressed and revised in the diff I put into the above 
review.
As for 4.2: the goal is merely the verification of the generated xml as it is 
similarly done in verifyExplainXmlComplexMR. Proper XML diffing would be 
difficult due to ever-changing scope numbers in the plan.

> Add xml format support for 'explain' in spark engine 
> -----------------------------------------------------
>
>                 Key: PIG-4815
>                 URL: https://issues.apache.org/jira/browse/PIG-4815
>             Project: Pig
>          Issue Type: Task
>          Components: spark
>            Reporter: Prateek Vaishnav
>            Assignee: Adam Szita
>             Fix For: spark-branch
>
>         Attachments: PIG-4815.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to