Koji Noguchi commented on PIG-4976:

bq.  if we need two separate test cases: one for non-existing file and one for 
existing file but syntactically incorrect script, or the one we have is enough

When the script has syntax error, there won't be file created so I don't see 
the need for 
"existing file but syntactically incorrect script" case.

Note that last patch updated the test case with two input sizes which did test 
both (1) and (2) that I mentioned above.  (at least on my mac)

We can create a new jira and discuss the meaning of non-existent or empty 
output file.
I haven't looked if we already have test cases for this. 
To me, process successful but no-output file should fail the task whereas 
process successful with empty output file should proceed with empty input.

> streaming job with store clause stuck if the script fail
> --------------------------------------------------------
>                 Key: PIG-4976
>                 URL: https://issues.apache.org/jira/browse/PIG-4976
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>             Fix For: 0.17.0
>         Attachments: PIG-4976-1.patch, PIG-4976-2.patch, PIG-4976-3.patch, 
> PIG-4976-4.patch, PIG-4976-5-knoguchi.patch
> When investigating PIG-4972, I also notice Pig job stuck when the perl script 
> have syntax error. This happens if we have output clause in stream 
> specification (means use a file as staging). The bug exist in both Tez and 
> MR, and it is not a regression.
> Here is an example:
> {code}
> define CMD `perl kk.pl` output('foo') ship('kk.pl');
> A = load 'studenttab10k' as (name, age, gpa);
> B = foreach A generate name;
> C = stream B through CMD;
> store C into 'ooo';
> {code}
> kk.pl is any perl script contain a syntax error.

This message was sent by Atlassian JIRA

Reply via email to