[
https://issues.apache.org/jira/browse/PIG-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645888#comment-15645888
]
Daniel Dai commented on PIG-5048:
---------------------------------
Thanks for the patch. A few comments:
* The only test case missing is UDTF with forward inside close
(GenericUDTFCount2), all other test cases are in e2e tests HiveUDF
* hive-contrib can be a test dependency rather than a compile dependency
* Didn't get your last change, collector need to be cleared for every record,
no matter normal process or endOfAllInput processing, clear is in favor as
newDefaultBag is more costly
The empty tuple only append to the result if the UDF require endOfAllInput.
Only HiveUDTF use this flag.
> HiveUDTF fail if it is the first expression in projection
> ---------------------------------------------------------
>
> Key: PIG-5048
> URL: https://issues.apache.org/jira/browse/PIG-5048
> Project: Pig
> Issue Type: Bug
> Components: impl
> Reporter: Daniel Dai
> Assignee: Nandor Kollar
> Fix For: 0.17.0, 0.16.1
>
> Attachments: PIG-5048-1.patch, PIG-5048-2.patch, PIG-5048.patch
>
>
> The following script fail:
> {code}
> define explode HiveUDTF('explode');
> A = load 'bag.txt' as (a0:{(b0:chararray)});
> B = foreach A generate explode(a0);
> dump B;
> {code}
> Message: Unimplemented at
> org.apache.pig.data.UnlimitedNullTuple.size(UnlimitedNullTuple.java:31)
> If it is not the first projection, the script pass:
> {code}
> define explode HiveUDTF('explode');
> A = load 'bag.txt' as (a0:{(b0:chararray)});
> B = foreach A generate a0, explode(a0);
> dump B;
> {code}
> Thanks [~nkollar] reporting it!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
