[ 
https://issues.apache.org/jira/browse/PIG-3417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15759517#comment-15759517
 ] 

Nandor Kollar edited comment on PIG-3417 at 12/18/16 9:28 PM:
--------------------------------------------------------------

Attached PIG-3417_2.patch with these changes:
- key tuple is not flattened, but statistics are
- golden files changed accordingly. TestTezCompiler test passed with these 
changes, and no test failed in TestMRCompiler
- added an assert for the output to testSkewJoinWithTuples and added an e2e 
test too

We might not even need to have testSkewJoinWithTuples, since the e2e tests now 
cover this case. [~rohini] could you please have have a look at the second 
version of my patch? 


was (Author: nkollar):
Attached PIG-3417_2.patch with these changes:
- key tuple is not flattened, but statistics are
- golden files changed accordingly. TestTezCompiler test passed with these 
changes, and no test failed in TestMRCompiler
- added an assert for the output to testSkewJoinWithTuples and added an e2e 
test too
We might not even need to have testSkewJoinWithTuples, since the e2e tests now 
cover this case. [~rohini] could you please have have a look at the second 
version of my patch? 

> Skewed Join On Tuple Column Kills Job 
> --------------------------------------
>
>                 Key: PIG-3417
>                 URL: https://issues.apache.org/jira/browse/PIG-3417
>             Project: Pig
>          Issue Type: Bug
>          Components: impl
>    Affects Versions: 0.11.1
>            Reporter: Nick White
>            Assignee: Nandor Kollar
>            Priority: Critical
>             Fix For: 0.17.0
>
>         Attachments: PIG-3417.patch, PIG-3417_2.patch, 
> TestSkewJoinWithTuples.java
>
>
> I've attached a test case that fails, but should pass. The test case groups 
> two relations separately, then full-outer joins them on the grouped columns. 
> The test case passes if "using 'skewed'" is removed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to