[
https://issues.apache.org/jira/browse/PIG-5132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879658#comment-15879658
]
liyunzhang_intel edited comment on PIG-5132 at 2/23/17 2:39 AM:
----------------------------------------------------------------
[~szita]: sorry for the mistake i made in PIG-5132.2.patch. The reason why i
not use PIG-5132.1.patch is because i need to delete directories like
shims/src/hadoop23 and others after i applying the patch. So i create
PIG-5132.2.patch. The problems in PIG-5132.2.patch is
{code}
1. XPathTest#testExecTupleWithDontIgnoreNamespace is present 3 times
2. XPathTest#testFunctionInXPath is present 2 times
3. Random whitespaces came into NonFSLoadFunc:21 and :22
4. not create directory shims/test/hadoop2
{code}
in PIG-5132.2.fix.patch, i fixed above 4 points and test them in my local
jenkins(see attached jenkins.5132.2.fix.png). Can you and [~nkollar] help
verify PIG-5132.2.fix.patch by following way? if anyone of you +1, i will
commit PIG-5132.2.fix.patch.
{code}
1. download latest code
the latest version is 1a2b4f3 - (origin/spark) PIG-5132:Merge from trunk
(5) [Spark Branch](Adam via Liyun) (15 hours ago)
2. unzip PIG-5132.2.fix.zip; git apply<PIG-5132.2.fix.patch #here please use
git apply to patch. if use patch -p1<xxx.patch, the directory
shims/test/hadoop2 will not be created.
3. ant -Dhadoopversion=2 jar
4. ant -Dhadoopversion=2 test-spark
{code}
After applying the patch , i found the unit test about TestPredeployedJar
passed. so ready to close the unit test failure.
was (Author: kellyzly):
[~szita]: sorry for the mistake i made in PIG-5132.2.patch. The reason why i
not use PIG-5132.1.patch is because i need to delete directories like
shims/src/hadoop23 and others after i applying the patch. So i create
PIG-5132.2.patch. The problems in PIG-5132.2.patch is
{code}
1. XPathTest#testExecTupleWithDontIgnoreNamespace is present 3 times
2. XPathTest#testFunctionInXPath is present 2 times
3. Random whitespaces came into NonFSLoadFunc:21 and :22
4. not create directory shims/test/hadoop2
{code}
in PIG-5132.2.fix.patch, i fixed above 4 points and test them in my local
jenkins(see attached jenkins.5132.2.fix.png). Can you and [~nkollar] help
verify PIG-5132.2.fix.patch by following way? if anyone of you +1, i will
commit PIG-5132.2.fix.patch.
{code}
1. download latest code
the latest version is 1a2b4f3 - (origin/spark) PIG-5132:Merge from trunk
(5) [Spark Branch](Adam via Liyun) (15 hours ago)
2. unzip PIG-5132.2.fix.zip; patch -p1<PIG-5132.2.fix.patch
3. please create shims/test/hadoop2/ manually because i could not patch this
changes in the patch file
4. ant -Dhadoopversion=2 jar
5. ant -Dhadoopversion=2 test-spark
{code}
After applying the patch , i found the unit test about TestPredeployedJar
passed. so ready to close the unit test failure.
> Merge from trunk (5) [Spark Branch]
> -----------------------------------
>
> Key: PIG-5132
> URL: https://issues.apache.org/jira/browse/PIG-5132
> Project: Pig
> Issue Type: Bug
> Components: spark
> Reporter: liyunzhang_intel
> Assignee: liyunzhang_intel
> Fix For: spark-branch
>
> Attachments: jenkins.5132.2.fix.PNG, PIG-5132.1_fixes.patch,
> PIG-5132.1.patch, PIG-5132.2.fix.zip, PIG-5132.2.zip, PIG-5132.patch
>
>
> merge changes from trunk to branch.
> the latest commit in trunk is
> 92df45d - (origin/trunk, origin/HEAD, trunk) PIG-5085: Support FLATTEN of
> maps (szita via rohini)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
