[
https://issues.apache.org/jira/browse/PIG-5248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohini Palaniswamy updated PIG-5248:
------------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
bq. Interesting that test is now catching the real issue. +1 on the patch.
As [~szita] mentioned, the test case was referring to the wrong alias and it
was corrected in the spark patch making the test case actually work as intended.
Committed to branch-0.17 and trunk. Thanks [~szita] for debugging the issue and
[~knoguchi] for reviewing it.
> Fix TestCombiner#testGroupByLimit after PigOnSpark merge
> --------------------------------------------------------
>
> Key: PIG-5248
> URL: https://issues.apache.org/jira/browse/PIG-5248
> Project: Pig
> Issue Type: Improvement
> Reporter: Adam Szita
> Assignee: Rohini Palaniswamy
> Fix For: 0.17.0
>
> Attachments: PIG-5248-1.patch
>
>
> This test started failing on TEZ after we merged PoS. The test checks if
> there is a "Combiner plan" among the vertices of Tez execution plan.
> The last step of the query is {{pigServer.registerQuery("d = limit c 2 ;
> ");}} which is decisive in the case of Tez. It looks like if we check the
> plan for "d" there is no combiner part, but there is one if we check it for
> "c" - so without applying limit.
> The reason this didn't come out before is because the alias supplied to
> {{checkCombinerUsed}} method was disregarded and alias "c" was checked
> always. This was recently fixed with the PoS merge. (See diff of TestCombiner
> [here|https://github.com/apache/pig/commit/e766b6bf29e610b6312f8447fc008bed6beb4090?diff=split#diff-8bcae39a2bb998cdfeb8c7af960eb196L360]
> )
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
