----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68980/#review209460 -----------------------------------------------------------
build.xml Lines 392 (patched) <https://reviews.apache.org/r/68980/#comment293880> Remove commented out code ivy/libraries.properties Lines 100 (patched) <https://reviews.apache.org/r/68980/#comment293882> roaring-bitmap.version can be removed src/org/apache/pig/backend/hadoop/executionengine/tez/plan/TezCompiler.java Line 1459 (original), 1458 (patched) <https://reviews.apache.org/r/68980/#comment293889> Revert changes to this file src/org/apache/pig/backend/hadoop/executionengine/tez/plan/operator/POBuildBloomRearrangeTez.java Line 213 (original), 213 (patched) <https://reviews.apache.org/r/68980/#comment293890> Fix tabs src/org/apache/pig/impl/bloom/HashFunction.java Lines 49-51 (patched) <https://reviews.apache.org/r/68980/#comment293898> Remove src/org/apache/pig/impl/bloom/HashFunction.java Lines 71 (patched) <https://reviews.apache.org/r/68980/#comment293892> return hashAlgorithm.hash src/org/apache/pig/impl/bloom/HashFunction.java Lines 72 (patched) <https://reviews.apache.org/r/68980/#comment293891> whitespace src/org/apache/pig/impl/bloom/JenkinsHash.java Lines 25 (patched) <https://reviews.apache.org/r/68980/#comment293895> private src/org/apache/pig/impl/bloom/PigBloomFilter.java Lines 106 (patched) <https://reviews.apache.org/r/68980/#comment293900> or src/org/apache/pig/impl/bloom/PigBloomFilter.java Lines 117 (patched) <https://reviews.apache.org/r/68980/#comment293901> xor src/org/apache/pig/impl/bloom/PigBloomFilter.java Lines 179 (patched) <https://reviews.apache.org/r/68980/#comment293902> Remove the log statements src/org/apache/pig/impl/bloom/PigBloomFilter.java Lines 186-187 (patched) <https://reviews.apache.org/r/68980/#comment293904> shouldn't the compressionOut.finish(); be first? src/org/apache/pig/impl/bloom/PigBloomFilter.java Lines 197 (patched) <https://reviews.apache.org/r/68980/#comment293903> ((compressionIn)) -> (compressionIn) src/org/apache/pig/impl/bloom/PigHash.java Lines 21 (patched) <https://reviews.apache.org/r/68980/#comment293899> Just call it HashFunction and BloomFilter instead of PigHash and PigBloomFilter. They are anyway in pig packages. src/org/apache/pig/impl/bloom/PigHash.java Lines 35 (patched) <https://reviews.apache.org/r/68980/#comment293896> jenkins, murmur, murmur3km src/org/apache/pig/impl/bloom/PigHash.java Lines 47 (patched) <https://reviews.apache.org/r/68980/#comment293897> Throw IllegalArgumentException exception here - Rohini Palaniswamy On Oct. 10, 2018, 4:48 p.m., Satish Saley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68980/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2018, 4:48 p.m.) > > > Review request for pig. > > > Repository: pig-git > > > Description > ------- > > [PIG-5255] Improvements to bloom join > > > Diffs > ----- > > build.xml b58aa35c3 > ivy.xml 0902b1804 > ivy/libraries.properties ec71472be > shade/roaringbitmap/pom.xml PRE-CREATION > src/org/apache/pig/backend/hadoop/executionengine/tez/plan/TezCompiler.java > 26ec5d722 > > src/org/apache/pig/backend/hadoop/executionengine/tez/plan/operator/BloomPackager.java > 1d6f78424 > > src/org/apache/pig/backend/hadoop/executionengine/tez/plan/operator/POBloomFilterRearrangeTez.java > 82b599dae > > src/org/apache/pig/backend/hadoop/executionengine/tez/plan/operator/POBuildBloomRearrangeTez.java > 40459422b > src/org/apache/pig/impl/bloom/HashFunction.java PRE-CREATION > src/org/apache/pig/impl/bloom/HashProvider.java PRE-CREATION > src/org/apache/pig/impl/bloom/JenkinsHash.java PRE-CREATION > src/org/apache/pig/impl/bloom/KirschMitzenmacherHash.java PRE-CREATION > src/org/apache/pig/impl/bloom/Murmur3Hash.java PRE-CREATION > src/org/apache/pig/impl/bloom/PigBloomFilter.java PRE-CREATION > src/org/apache/pig/impl/bloom/PigHash.java PRE-CREATION > src/org/apache/pig/impl/util/JarManager.java e6c9215d8 > test/org/apache/pig/test/TestJobControlCompiler.java 2c39964ac > > > Diff: https://reviews.apache.org/r/68980/diff/2/ > > > Testing > ------- > > > Thanks, > > Satish Saley > >
