kishoreg commented on a change in pull request #3470: [PINOT-7328] Reduce lock
contention in physical planning phase by reducing the total number of tasks
URL: https://github.com/apache/incubator-pinot/pull/3470#discussion_r233078264
##########
File path:
pinot-core/src/main/java/com/linkedin/pinot/core/plan/CombinePlanNode.java
##########
@@ -36,7 +36,7 @@
public class CombinePlanNode implements PlanNode {
private static final Logger LOGGER =
LoggerFactory.getLogger(CombinePlanNode.class);
- private static final int NUM_PLAN_NODES_THRESHOLD_FOR_PARALLEL_RUN = 10;
+ private static final int MAX_PLAN_TASKS = Math.min(10, (int)
(Runtime.getRuntime().availableProcessors() * .5));
Review comment:
Is this max plan tasks per thread or max threads? Looks like it’s used as
both.
Is the goal to have
1 - fixed number of threads, variable number of segments or
2 - fixed number of segments per thread, variable threads?
3 - hybrid where we prefer option 2 but limit number of threads
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
