mayankshriv commented on a change in pull request #3472: Misc Cleanup: Removed
unused member variable from FixedByteSingleValueMultiColWriter.
URL: https://github.com/apache/incubator-pinot/pull/3472#discussion_r233165709
##########
File path:
pinot-core/src/main/java/com/linkedin/pinot/core/io/writer/impl/FixedByteSingleValueMultiColWriter.java
##########
@@ -24,14 +24,10 @@
public class FixedByteSingleValueMultiColWriter {
private int[] columnOffsets;
- private int rows;
private PinotDataBuffer indexDataBuffer;
private int rowSizeInBytes;
- public FixedByteSingleValueMultiColWriter(File file, int rows, int cols,
- int[] columnSizes)
- throws IOException {
- this.rows = rows;
+ public FixedByteSingleValueMultiColWriter(File file, int rows, int cols,
int[] columnSizes) throws IOException {
Review comment:
That cannot be removed, because it is used to compute the total size for
mmaping in this constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
