mcvsubbu commented on a change in pull request #3476: Fix the bug where
realtime time conversion is skipped when incoming and outgoing time name are
the same
URL: https://github.com/apache/incubator-pinot/pull/3476#discussion_r233544230
##########
File path:
pinot-core/src/main/java/com/linkedin/pinot/core/data/recordtransformer/CompoundTransformer.java
##########
@@ -30,20 +30,38 @@
private final List<RecordTransformer> _transformers;
/**
- * Returns a record transformer that performs time transform, expressions
transform and data type transform.
+ * Returns a record transformer for OFFLINE segment generation that performs
expressions transform and data type
+ * transform.
+ * <p>NOTE: NO TIME TRANSFORMATION
+ * <p>NOTE: DO NOT CHANGE THE ORDER OF THE RECORD TRANSFORMERS
+ * <ul>
+ * <li>
+ * We put {@link SanitationTransformer} after {@link
DataTypeTransformer} so that before sanitation, all values
+ * follow the data types defined in the {@link Schema}.
+ * </li>
+ * </ul>
+ */
+ public static CompoundTransformer getOfflineTransformer(Schema schema) {
Review comment:
Would it be better to use a builder pattern here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
