jackjlli commented on a change in pull request #3475: Enhance controller
periodic task and scheduler
URL: https://github.com/apache/incubator-pinot/pull/3475#discussion_r233641509
##########
File path:
pinot-controller/src/main/java/com/linkedin/pinot/controller/validation/ValidationManager.java
##########
@@ -60,8 +60,7 @@
public ValidationManager(ControllerConf config, PinotHelixResourceManager
pinotHelixResourceManager,
PinotLLCRealtimeSegmentManager llcRealtimeSegmentManager,
ValidationMetrics validationMetrics) {
- super("ValidationManager",
config.getValidationControllerFrequencyInSeconds(),
- config.getValidationControllerFrequencyInSeconds() / 2,
pinotHelixResourceManager);
Review comment:
The purpose of making the initial delay to
`config.getValidationControllerFrequencyInSeconds() / 2` is to stagger the
execution time of validation manager and pinot task manager.
Not sure the change is what we need.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
