codecov-io commented on issue #3475: Enhance controller periodic task and scheduler URL: https://github.com/apache/incubator-pinot/pull/3475#issuecomment-438883660 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3475?src=pr&el=h1) Report > Merging [#3475](https://codecov.io/gh/apache/incubator-pinot/pull/3475?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/c9a4e60c44b9bc37e7c314d3d6bd8849042ca014?src=pr&el=desc) will **increase** coverage by `0.08%`. > The diff coverage is `89.06%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/3475?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #3475 +/- ## ============================================ + Coverage 70.58% 70.66% +0.08% Complexity 4 4 ============================================ Files 999 999 Lines 45669 45664 -5 Branches 6109 6109 ============================================ + Hits 32236 32270 +34 + Misses 11329 11266 -63 - Partials 2104 2128 +24 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3475?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...edin/pinot/core/periodictask/BasePeriodicTask.java](https://codecov.io/gh/apache/incubator-pinot/pull/3475/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3BlcmlvZGljdGFzay9CYXNlUGVyaW9kaWNUYXNrLmphdmE=) | `70% <0%> (-30%)` | `0 <0> (ø)` | | | [...elix/core/relocation/RealtimeSegmentRelocator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3475/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcmVsb2NhdGlvbi9SZWFsdGltZVNlZ21lbnRSZWxvY2F0b3IuamF2YQ==) | `73.95% <100%> (-6.25%)` | `0 <0> (ø)` | | | [...elix/core/periodictask/ControllerPeriodicTask.java](https://codecov.io/gh/apache/incubator-pinot/pull/3475/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcGVyaW9kaWN0YXNrL0NvbnRyb2xsZXJQZXJpb2RpY1Rhc2suamF2YQ==) | `97.14% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...troller/helix/core/retention/RetentionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3475/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcmV0ZW50aW9uL1JldGVudGlvbk1hbmFnZXIuamF2YQ==) | `76.92% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...n/pinot/controller/helix/SegmentStatusChecker.java](https://codecov.io/gh/apache/incubator-pinot/pull/3475/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L1NlZ21lbnRTdGF0dXNDaGVja2VyLmphdmE=) | `84.61% <100%> (-2.41%)` | `0 <0> (ø)` | | | [...m/linkedin/pinot/controller/ControllerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3475/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL0NvbnRyb2xsZXJTdGFydGVyLmphdmE=) | `61.84% <100%> (+0.86%)` | `0 <0> (ø)` | :arrow_down: | | [...pinot/controller/validation/ValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3475/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL3ZhbGlkYXRpb24vVmFsaWRhdGlvbk1hbmFnZXIuamF2YQ==) | `66.42% <100%> (+39.47%)` | `0 <0> (ø)` | :arrow_down: | | [...controller/helix/core/minion/PinotTaskManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3475/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvbWluaW9uL1Bpbm90VGFza01hbmFnZXIuamF2YQ==) | `83.67% <66.66%> (-0.33%)` | `0 <0> (ø)` | | | [...pinot/core/periodictask/PeriodicTaskScheduler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3475/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3BlcmlvZGljdGFzay9QZXJpb2RpY1Rhc2tTY2hlZHVsZXIuamF2YQ==) | `86.66% <84%> (+10.66%)` | `0 <0> (ø)` | :arrow_down: | | [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3475/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2RhdGEvbWFuYWdlci9yZWFsdGltZS9SZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `50% <0%> (-50%)` | `0% <0%> (ø)` | | | ... and [36 more](https://codecov.io/gh/apache/incubator-pinot/pull/3475/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3475?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3475?src=pr&el=footer). Last update [c9a4e60...4c27e47](https://codecov.io/gh/apache/incubator-pinot/pull/3475?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
