apucher closed pull request #3519: [TE] rootcause - prevent line-break of
exclude/hide links in filter selector
URL: https://github.com/apache/incubator-pinot/pull/3519
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/thirdeye/thirdeye-frontend/app/pods/components/rootcause-select-metric-dimension/template.hbs
b/thirdeye/thirdeye-frontend/app/pods/components/rootcause-select-metric-dimension/template.hbs
index 7fa3e36740..c155cce605 100644
---
a/thirdeye/thirdeye-frontend/app/pods/components/rootcause-select-metric-dimension/template.hbs
+++
b/thirdeye/thirdeye-frontend/app/pods/components/rootcause-select-metric-dimension/template.hbs
@@ -21,17 +21,15 @@
<div class="{{if showExclusions 'col-xs-3' 'col-xs-6'}}">
<label class="te-label te-label--small" for="select-filters">
Filter by
+ {{#unless showExclusions}}
+ <a {{action "showExclusions"}}>Exclude</a>
+ {{/unless}}
<span>
<i class="glyphicon glyphicon-question-sign"></i>
{{#tooltip-on-element class="te-tooltip"}}
You can add filters to the analyzed metric, for example page views
for "countryCode::us" only. The available filters depend on the data set. You
can also add filters via left-click in the "Dimensions" tab.
{{/tooltip-on-element}}
</span>
- {{#unless showExclusions}}
- <span>
- <a {{action "showExclusions"}}>Exclude</a>
- </span>
- {{/unless}}
</label>
{{filter-select
@@ -50,17 +48,15 @@
{{partial 'partials/rootcause/exclusion-warning'}}
{{/if}}
Exclude
+ {{#unless hasExclusions}}
+ <a {{action "hideExclusions"}}>Hide</a>
+ {{/unless}}
<span>
<i class="glyphicon glyphicon-question-sign"></i>
{{#tooltip-on-element class="te-tooltip"}}
You can exclude subsets of the analyzed metric, for example all
page views without "countryCode::us". The available exclusions depend on the
data set. You can also add exclusions via right-click in the "Dimensions" tab.
{{/tooltip-on-element}}
- </span>
- {{#unless hasExclusions}}
- <span>
- <a {{action "hideExclusions"}}>Hide</a>
- </span>
- {{/unless}}
+ </span>
</label>
{{filter-select
selected=exclusions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
