apucher closed pull request #3520: [TE] Organize the Holiday list in the alert
email
URL: https://github.com/apache/incubator-pinot/pull/3520
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/thirdeye/thirdeye-pinot/src/main/resources/com/linkedin/thirdeye/detector/holiday-anomaly-report.ftl
b/thirdeye/thirdeye-pinot/src/main/resources/com/linkedin/thirdeye/detector/holiday-anomaly-report.ftl
index 0b13c7828a..30d67edc1a 100644
---
a/thirdeye/thirdeye-pinot/src/main/resources/com/linkedin/thirdeye/detector/holiday-anomaly-report.ftl
+++
b/thirdeye/thirdeye-pinot/src/main/resources/com/linkedin/thirdeye/detector/holiday-anomaly-report.ftl
@@ -118,7 +118,7 @@
</#list>
<#if referenceLinks?has_content>
- <@utils.addRow title="Useful Links" align="center">
+ <@utils.addRow title="Useful Links" align="left">
<#list referenceLinks?keys as referenceLinkKey>
<div style="padding-top: 16px;">
<a href="${referenceLinks[referenceLinkKey]}"
style="text-decoration: none; color:#0073B1; font-size:14px; font-weight:bold;
line-height:20px; margin-bottom: 0;">${referenceLinkKey}</a>
@@ -128,18 +128,28 @@
</#if>
<#if holidays?has_content>
- <@utils.addRow title="Holidays" align="center">
- <#list holidays as holiday>
- <div style="padding-top: 16px;">
- <a href="https://www.google.com/search?q=${holiday.name}";
style="text-decoration: none; color:#0073B1; font-size:14px; font-weight:bold;
line-height:20px; margin-bottom: 0;">${holiday.name}</a>
- <span style="font-size: 14px; color:#606060;
line-height:20px;">(${holiday.startTime?number_to_date})</span>
- </div>
- <#if holiday.targetDimensionMap?has_content>
- <#list holiday.targetDimensionMap?keys as dimension>
- <span style="color: rgba(0,0,0,0.6); line-height:16px;
font-size: 12px;">${holiday.targetDimensionMap[dimension]?join(",")}</span>
- </#list>
- </#if>
- </#list>
+ <@utils.addRow title="Holidays" align="left">
+ <table border="0" width="100%" align="center" style="width:100%;
padding:0; margin:0; border-collapse: collapse; text-align:left;">
+ <#list holidays as holiday>
+ <tr style="border-bottom: 1px solid #C7D1D8;">
+
+ <td style="padding:14px 24px;">
+ <a
href="https://www.google.com/search?q=${holiday.name}"; style="text-decoration:
none; white-space:nowrap; color:#0073B1; font-size:14px;
font-weight:bold;">${holiday.name}</a>
+ </td>
+
+ <td style="padding:14px 24px;">
+ <span style=" white-space:nowrap; font-size: 14px;
color:#606060;">(${holiday.startTime?number_to_date})</span>
+ </td>
+
+ <#if holiday.targetDimensionMap["countryCode"]??>
+ <td style="padding:14px 24px;">
+ <span style="color: rgba(0,0,0,0.6); font-size:
12px;">${holiday.targetDimensionMap["countryCode"]?join(", ")}</span>
+ </td>
+ </#if>
+
+ </tr>
+ </#list>
+ </table>
</@utils.addRow>
</#if>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
