sunithabeeram commented on a change in pull request #3528: Adding support for
bloom filter
URL: https://github.com/apache/incubator-pinot/pull/3528#discussion_r235206214
##########
File path:
pinot-common/src/main/java/com/linkedin/pinot/common/config/IndexingConfig.java
##########
@@ -113,6 +116,15 @@ public void setSortedColumn(List<String> sortedColumn) {
_sortedColumn = sortedColumn;
}
+
+ public List<String> getBloomFilterColumns() {
Review comment:
Does this need to be a separate config? Could we add this for all indexed
columns? If we pursue the size based optimizations you mention, then the
overhead would be somewhat contained.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
