sunithabeeram commented on a change in pull request #3525: Adding execution
stats for numSegmentsQueried/Processed/Matched
URL: https://github.com/apache/incubator-pinot/pull/3525#discussion_r235453436
##########
File path:
pinot-core/src/main/java/com/linkedin/pinot/core/query/scheduler/QueryScheduler.java
##########
@@ -160,14 +166,17 @@ public void stop() {
}
TimerContext timerContext = queryRequest.getTimerContext();
+ int numSegmentsQueried = queryRequest.getSegmentsToQuery().size();
LOGGER.info(
- "Processed
requestId={},table={},reqSegments={},prunedToSegmentCount={},totalExecMs={},totalTimeMs={},broker={},numDocsScanned={},scanInFilter={},scanPostFilter={},sched={}",
- requestId, tableNameWithType, queryRequest.getSegmentsToQuery().size(),
- queryRequest.getSegmentCountAfterPruning(),
timerContext.getPhaseDurationMs(ServerQueryPhase.QUERY_PROCESSING),
+ "Processed
requestId={},table={},Segments={}/{}/{},totalExecMs={},totalTimeMs={},broker={},numDocsScanned={},scanInFilter={},scanPostFilter={},sched={}",
Review comment:
It will be good to update the log to say Segments(queried/processed/matched)
- else it might be hard for someone who isn't familiar with the code to figure
out what they represent; or we can log them separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
