sunithabeeram commented on a change in pull request #3535: Optimize all filter
predicates by adding isAlwaysTrue()
URL: https://github.com/apache/incubator-pinot/pull/3535#discussion_r236297962
##########
File path:
pinot-core/src/main/java/com/linkedin/pinot/core/operator/filter/predicate/NotEqualsPredicateEvaluatorFactory.java
##########
@@ -75,8 +75,12 @@ public static BaseRawValueBasedPredicateEvaluator
newRawValueBasedEvaluator(NEqP
_nonMatchingDictId =
dictionary.indexOf(nEqPredicate.getNotEqualsValue());
if (_nonMatchingDictId >= 0) {
_nonMatchingDictIds = new int[]{_nonMatchingDictId};
+ if (dictionary.length() == 1) {
Review comment:
ok, makes sense - I might have been thinking about the not-in predicate. The
non-matching id is present in the dictionary and the length of the dict is 1;
in this case nothing will get ever get picked up by the predicate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
