apucher closed pull request #3540: [TE] detection - add more logs for merger
for debugging
URL: https://github.com/apache/incubator-pinot/pull/3540
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/thirdeye/thirdeye-pinot/src/main/java/com/linkedin/thirdeye/anomaly/merge/AnomalyTimeBasedSummarizer.java
b/thirdeye/thirdeye-pinot/src/main/java/com/linkedin/thirdeye/anomaly/merge/AnomalyTimeBasedSummarizer.java
index ca974648a9..9e8ca0ef69 100644
---
a/thirdeye/thirdeye-pinot/src/main/java/com/linkedin/thirdeye/anomaly/merge/AnomalyTimeBasedSummarizer.java
+++
b/thirdeye/thirdeye-pinot/src/main/java/com/linkedin/thirdeye/anomaly/merge/AnomalyTimeBasedSummarizer.java
@@ -86,6 +86,7 @@ public int compare(AnomalyResult o1, AnomalyResult o2) {
for (int i = 0; i < anomalies.size(); i++) {
AnomalyResult currentResult = anomalies.get(i);
+ LOG.info("Current anomaly start =[{}], end = [{}].",
currentResult.getStartTime(), currentResult.getEndTime());
if (mergedAnomaly == null || currentResult.getEndTime() <
mergedAnomaly.getStartTime()) {
mergedAnomaly = new MergedAnomalyResultDTO(currentResult);
} else {
@@ -122,7 +123,14 @@ public int compare(AnomalyResult o1, AnomalyResult o2) {
mergedAnomalies.add(mergedAnomaly);
}
}
- LOG.info("merging [{}] raw anomalies", anomalies.size());
+
+ if (mergedAnomaly != null) {
+ LOG.info("merging [{}] raw anomalies, latest merged anomaly start =[{}],
end = [{}], merged anomalies size [{}]",
+ anomalies.size(), mergedAnomaly.getStartTime(),
mergedAnomaly.getEndTime(), mergedAnomalies.size());
+ } else {
+ LOG.info("merging [{}] raw anomalies", anomalies.size());
+ }
+
return mergedAnomalies;
}
diff --git
a/thirdeye/thirdeye-pinot/src/main/java/com/linkedin/thirdeye/anomaly/merge/TimeBasedAnomalyMerger.java
b/thirdeye/thirdeye-pinot/src/main/java/com/linkedin/thirdeye/anomaly/merge/TimeBasedAnomalyMerger.java
index 6807af86e9..3b8170ebb2 100644
---
a/thirdeye/thirdeye-pinot/src/main/java/com/linkedin/thirdeye/anomaly/merge/TimeBasedAnomalyMerger.java
+++
b/thirdeye/thirdeye-pinot/src/main/java/com/linkedin/thirdeye/anomaly/merge/TimeBasedAnomalyMerger.java
@@ -185,7 +185,10 @@ public TimeBasedAnomalyMerger(AnomalyFunctionFactory
anomalyFunctionFactory) {
MergedAnomalyResultDTO latestOverlappedMergedResult =
mergedResultDAO.findLatestOverlapByFunctionIdDimensions(function.getId(),
dimensionMap.toString(),
anomalyWindowStart - mergeConfig.getSequentialAllowedGap(),
anomalyWindowEnd);
-
+ if (latestOverlappedMergedResult != null) {
+ LOG.info("Fetched anomaly id [{}] from time window start = [{}], end =
[{}]", latestOverlappedMergedResult.getId(),
+ anomalyWindowStart - mergeConfig.getSequentialAllowedGap(),
anomalyWindowEnd);
+ }
List<MergedAnomalyResultDTO> mergedResults =
AnomalyTimeBasedSummarizer.mergeAnomalies(latestOverlappedMergedResult,
unmergedResultsByDimensions,
mergeConfig);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
