mcvsubbu commented on a change in pull request #3541: Adding pluggable storage
support for realtime upload
URL: https://github.com/apache/incubator-pinot/pull/3541#discussion_r236450962
##########
File path:
pinot-controller/src/main/java/com/linkedin/pinot/controller/api/resources/LLCSegmentCompletionHandlers.java
##########
@@ -300,27 +303,48 @@ private String uploadSegment(FormDataMultiPart
multiPart, String instanceId, Str
FormDataBodyPart bodyPart = map.get(name).get(0);
FileUploadPathProvider provider = new
FileUploadPathProvider(_controllerConf);
- File tmpFile = new File(provider.getFileUploadTmpDir(), name + "." +
UUID.randomUUID().toString());
- tmpFile.deleteOnExit();
+ String tmpFilePath = StringUtil.join("/",
provider.getFileUploadTmpDirURI().toString(), name + "." +
UUID.randomUUID().toString());
Review comment:
can we name the variables localTmpFile, and remoteTmpFile so as to make it
less confusing? Or, a better naming scheme if you have.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
