codecov-io edited a comment on issue #3535: Optimize all filter predicates by adding isAlwaysTrue() URL: https://github.com/apache/incubator-pinot/pull/3535#issuecomment-440897833 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3535?src=pr&el=h1) Report > Merging [#3535](https://codecov.io/gh/apache/incubator-pinot/pull/3535?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/37ad801ad65464bd653d6ac03ad255de0322ce60?src=pr&el=desc) will **increase** coverage by `0.13%`. > The diff coverage is `88.99%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/3535?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #3535 +/- ## ============================================ + Coverage 70.73% 70.87% +0.13% Complexity 4 4 ============================================ Files 998 997 -1 Lines 45722 45758 +36 Branches 6112 6135 +23 ============================================ + Hits 32341 32429 +88 + Misses 11264 11198 -66 - Partials 2117 2131 +14 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3535?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...predicate/RegexpLikePredicateEvaluatorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/3535/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2ZpbHRlci9wcmVkaWNhdGUvUmVnZXhwTGlrZVByZWRpY2F0ZUV2YWx1YXRvckZhY3RvcnkuamF2YQ==) | `29.16% <ø> (-2.84%)` | `0 <0> (ø)` | | | [...ore/operator/filter/BitmapBasedFilterOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3535/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2ZpbHRlci9CaXRtYXBCYXNlZEZpbHRlck9wZXJhdG9yLmphdmE=) | `85.29% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...filter/SortedInvertedIndexBasedFilterOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3535/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2ZpbHRlci9Tb3J0ZWRJbnZlcnRlZEluZGV4QmFzZWRGaWx0ZXJPcGVyYXRvci5qYXZh) | `78% <0%> (-8%)` | `0 <0> (ø)` | | | [.../predicate/NotEqualsPredicateEvaluatorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/3535/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2ZpbHRlci9wcmVkaWNhdGUvTm90RXF1YWxzUHJlZGljYXRlRXZhbHVhdG9yRmFjdG9yeS5qYXZh) | `85.24% <100%> (-6.28%)` | `0 <0> (ø)` | | | [...edicate/BaseDictionaryBasedPredicateEvaluator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3535/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2ZpbHRlci9wcmVkaWNhdGUvQmFzZURpY3Rpb25hcnlCYXNlZFByZWRpY2F0ZUV2YWx1YXRvci5qYXZh) | `59.09% <100%> (+4.09%)` | `0 <0> (ø)` | :arrow_down: | | [...ter/predicate/EqualsPredicateEvaluatorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/3535/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2ZpbHRlci9wcmVkaWNhdGUvRXF1YWxzUHJlZGljYXRlRXZhbHVhdG9yRmFjdG9yeS5qYXZh) | `91.48% <100%> (+0.37%)` | `0 <0> (ø)` | :arrow_down: | | [...pinot/core/operator/filter/BaseFilterOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3535/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2ZpbHRlci9CYXNlRmlsdGVyT3BlcmF0b3IuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...a/com/linkedin/pinot/core/plan/FilterPlanNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/3535/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3BsYW4vRmlsdGVyUGxhbk5vZGUuamF2YQ==) | `89.74% <100%> (-0.74%)` | `0 <0> (ø)` | | | [...inot/core/operator/filter/EmptyFilterOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3535/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2ZpbHRlci9FbXB0eUZpbHRlck9wZXJhdG9yLmphdmE=) | `85.71% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...inot/core/operator/filter/FilterOperatorUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/3535/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2ZpbHRlci9GaWx0ZXJPcGVyYXRvclV0aWxzLmphdmE=) | `84.37% <100%> (+8.61%)` | `0 <0> (ø)` | :arrow_down: | | ... and [44 more](https://codecov.io/gh/apache/incubator-pinot/pull/3535/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3535?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3535?src=pr&el=footer). Last update [37ad801...3e20ed0](https://codecov.io/gh/apache/incubator-pinot/pull/3535?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
