mayankshriv commented on a change in pull request #3556: Fixing AzurePinotFS
Move API
URL: https://github.com/apache/incubator-pinot/pull/3556#discussion_r237195330
##########
File path:
pinot-azure-filesystem/src/main/java/com/linkedin/pinot/filesystem/AzurePinotFS.java
##########
@@ -99,8 +99,7 @@ public boolean move(URI srcUri, URI dstUri, boolean
overwrite) throws IOExceptio
if (exists(dstUri) && !overwrite) {
return false;
}
- //rename the file
- return _adlStoreClient.rename(srcUri.getPath(), dstUri.getPath());
+ return copy(srcUri, dstUri) && delete(srcUri, true);
Review comment:
Could you elaborate how the rename() api is different from copy() && delete()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
