codecov-io commented on issue #3568: Add guava cache to cache table schema in pinot broker URL: https://github.com/apache/incubator-pinot/pull/3568#issuecomment-443390975 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3568?src=pr&el=h1) Report > Merging [#3568](https://codecov.io/gh/apache/incubator-pinot/pull/3568?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/f1512e6774bffa17196242af7d7bab625cfc2142?src=pr&el=desc) will **decrease** coverage by `12.05%`. > The diff coverage is `34.28%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/3568?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #3568 +/- ## ============================================= - Coverage 70.88% 58.82% -12.06% Complexity 4 4 ============================================= Files 997 1148 +151 Lines 45779 58266 +12487 Branches 6137 8066 +1929 ============================================= + Hits 32449 34274 +1825 - Misses 11208 21612 +10404 - Partials 2122 2380 +258 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3568?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...m/linkedin/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2NvbW1vbi91dGlscy9Db21tb25Db25zdGFudHMuamF2YQ==) | `39.58% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...roker/requesthandler/BaseBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9yZXF1ZXN0aGFuZGxlci9CYXNlQnJva2VyUmVxdWVzdEhhbmRsZXIuamF2YQ==) | `67.64% <10%> (-11.96%)` | `0 <0> (ø)` | | | [...kedin/pinot/broker/broker/BrokerServerBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9icm9rZXIvQnJva2VyU2VydmVyQnVpbGRlci5qYXZh) | `91.66% <100%> (+0.14%)` | `0 <0> (ø)` | :arrow_down: | | [...com/linkedin/pinot/common/metrics/BrokerMeter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2NvbW1vbi9tZXRyaWNzL0Jyb2tlck1ldGVyLmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../pinot/broker/broker/helix/HelixBrokerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9icm9rZXIvaGVsaXgvSGVsaXhCcm9rZXJTdGFydGVyLmphdmE=) | `72.88% <100%> (+0.7%)` | `0 <0> (ø)` | :arrow_down: | | [...thandler/SingleConnectionBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9yZXF1ZXN0aGFuZGxlci9TaW5nbGVDb25uZWN0aW9uQnJva2VyUmVxdWVzdEhhbmRsZXIuamF2YQ==) | `88.09% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...esthandler/ConnectionPoolBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9yZXF1ZXN0aGFuZGxlci9Db25uZWN0aW9uUG9vbEJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `88.05% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../pinot/broker/requesthandler/TableSchemaCache.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9yZXF1ZXN0aGFuZGxlci9UYWJsZVNjaGVtYUNhY2hlLmphdmE=) | `50% <50%> (ø)` | `0 <0> (?)` | | | [...egation/function/customobject/MinMaxRangePair.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L2FnZ3JlZ2F0aW9uL2Z1bmN0aW9uL2N1c3RvbW9iamVjdC9NaW5NYXhSYW5nZVBhaXIuamF2YQ==) | `75.86% <0%> (-24.14%)` | `0% <0%> (ø)` | | | [...mpl/dictionary/DoubleOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Eb3VibGVPZmZIZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `65.45% <0%> (-18.19%)` | `0% <0%> (ø)` | | | ... and [178 more](https://codecov.io/gh/apache/incubator-pinot/pull/3568/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3568?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3568?src=pr&el=footer). Last update [f1512e6...eed8217](https://codecov.io/gh/apache/incubator-pinot/pull/3568?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
