kishoreg commented on a change in pull request #3506: Add configuration merging tool URL: https://github.com/apache/incubator-pinot/pull/3506#discussion_r238541540
########## File path: pinot-tools/src/main/java/com/linkedin/pinot/tools/admin/command/MergeConfigsCommand.java ########## @@ -0,0 +1,689 @@ +/** + * Copyright (C) 2014-2018 LinkedIn Corp. ([email protected]) + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.linkedin.pinot.tools.admin.command; + +import com.google.common.base.Splitter; +import com.linkedin.pinot.tools.Command; +import com.typesafe.config.Config; +import com.typesafe.config.ConfigFactory; +import com.typesafe.config.ConfigIncludeContext; +import com.typesafe.config.ConfigIncluder; +import com.typesafe.config.ConfigObject; +import com.typesafe.config.ConfigParseOptions; +import com.typesafe.config.ConfigRenderOptions; +import com.typesafe.config.ConfigValue; +import com.typesafe.config.ConfigValueFactory; +import com.typesafe.config.impl.ConfigReferenceHelper; +import io.vavr.Tuple; +import io.vavr.Tuple2; +import io.vavr.collection.HashMap; +import io.vavr.collection.HashSet; +import io.vavr.collection.List; +import io.vavr.collection.Map; +import io.vavr.collection.Seq; +import io.vavr.collection.Set; +import io.vavr.control.Either; +import io.vavr.control.Option; +import java.io.File; +import java.io.IOException; +import java.util.Collection; +import java.util.function.Function; +import java.util.regex.Matcher; +import java.util.regex.Pattern; +import org.apache.commons.io.FileUtils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * Command to merge config files coming from different Pinot clusters to avoid repeated values. + */ +public class MergeConfigsCommand extends AbstractBaseAdminCommand implements Command { + private static final Logger LOGGER = LoggerFactory.getLogger(MergeConfigsCommand.class); + private static final String[] CONFIG_FILE_EXTENSIONS = {"conf"}; + private static final String PROFILE_SEPARATOR = "___"; + + @org.kohsuke.args4j.Option(name = "-inputDir", required = true, metaVar = "<String>", usage = "Input directory containing configuration files to merge.") + private String _inputDir; + + @org.kohsuke.args4j.Option(name = "-outputDir", required = false, metaVar = "<String>", usage = "Output directory for the merged configuration files.") + private String _outputDir; + + @org.kohsuke.args4j.Option(name = "-profileDir", required = false, metaVar = "<String>", usage = "Directory containing configuration profiles.") + private String _profileDir; + + // jfim: Since there's no typedef in Java, use a generic parameter for the config value type (it gets erased to + // Object, but makes the types below clearer) + private <TYPE> boolean executeInternal() throws Exception { + // Build a list of all input files and their associated configuration profiles + LOGGER.info("Searching for configs..."); + + File inputDir = new File(_inputDir); + if (!inputDir.exists()) { + throw new RuntimeException("Input directory " + inputDir + " does not exist!"); + } else if (!inputDir.isDirectory()) { + throw new RuntimeException("Input directory " + inputDir + " is not a directory!"); + } + + List<File> configFiles = List.ofAll(FileUtils.listFiles(inputDir, CONFIG_FILE_EXTENSIONS, true)); + + List<Tuple2<File, Set<String>>> configFilesAndProfiles = configFiles.map(configFile -> { + File currentFile = configFile.getParentFile(); + Set<String> configurationProfiles = HashSet.empty(); + + // Iterate through parent files until the config directory is found to build the set of configuration profiles + // that apply to this particular configuration file + while(!currentFile.equals(inputDir)) { + configurationProfiles = configurationProfiles.add(currentFile.getName()); + + File parentOfCurrentFile = currentFile.getParentFile(); + if (parentOfCurrentFile != null) { + currentFile = parentOfCurrentFile; + } else { + throw new RuntimeException("Failed to get parent of " + currentFile.getPath() + " while finding configuration profiles for " + configFile.getPath()); + } + } + + return Tuple.of(configFile, configurationProfiles); + }); + + LOGGER.info("Found {} config files", configFilesAndProfiles.length()); + + // Load all the configuration profiles + LOGGER.info("Loading all configuration profiles..."); + + if (_profileDir == null) { + _profileDir = "." + File.separator + "profiles"; + } + File profileDir = new File(_profileDir); + + List<Tuple2<String, Config>> profileConfigurations; + if (!profileDir.exists()) { + System.out.println("Input directory " + inputDir + " does not exist."); + profileConfigurations = List.empty(); + } else if (!inputDir.isDirectory()) { + throw new RuntimeException("Input directory " + inputDir + " is not a directory!"); + } else { + profileConfigurations = List + .ofAll(FileUtils.listFiles(profileDir, CONFIG_FILE_EXTENSIONS, true)) + .map(file -> { + Config config = loadConfigFromFile(file); + String configName = file.getName().replaceAll("\\.conf$", ""); + + return Tuple.of(configName, config); + }); + } + + LOGGER.info("Loaded {} configuration profiles: {}", profileConfigurations.length(), profileConfigurations.map(Tuple2::_1).asJava()); + + // Build a map of value to configuration key for each configuration profile + Map<TYPE, Map<String, Set<String>>> valueToProfileAndKeys = profileConfigurations + .map(profileNameAndConfigTuple -> { + String profileName = profileNameAndConfigTuple._1; + Config config = profileNameAndConfigTuple._2; + + Seq<Tuple2<TYPE, String>> configValuesAndKeys = HashSet + .ofAll(config.entrySet()) + .toList() + .map(entry -> Tuple.of((TYPE) entry.getValue().unwrapped(), entry.getKey())); + + return Tuple.of(profileName, configValuesAndKeys); + }) + .flatMap(profileAndValueKeyTuples -> { + String profileName = profileAndValueKeyTuples._1; + Seq<Tuple2<TYPE, String>> valuesAndKeys = profileAndValueKeyTuples._2; + + return valuesAndKeys + .map(valueAndKeyTuple -> { + TYPE value = valueAndKeyTuple._1; + String key = valueAndKeyTuple._2; + + return Tuple.of(value, profileName, key); + }); + }) + .groupBy(valuesProfilesAndKeys -> valuesProfilesAndKeys._1) + .map((value, valueProfileKeyTriples) -> { + Map<String, Set<String>> profilesAndKeys = valueProfileKeyTriples + .groupBy(valueProfileKeyTriple -> valueProfileKeyTriple._2) + .map((profile, valueProfileKeyTriples2) -> { + Set<String> keys = valueProfileKeyTriples2 + .map(valueProfileKeyTriple -> valueProfileKeyTriple._3) + .toSet(); + + return Tuple.of(profile, keys); + }) + .toMap(Function.identity()); + + return Tuple.of(value, profilesAndKeys); + }) + .toMap(Function.identity()) + .removeKeys(key -> key.toString().trim().isEmpty()); + + // Group input files by their name + Map<String, Config> mergedConfigs = configFilesAndProfiles + .groupBy(configFileAndProfiles -> configFileAndProfiles._1.getName()) + .map((configFilename, configFileAndProfilesTuples) -> { + System.out.print("\rWorking on " + configFilename + " "); Review comment: use logger ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
