codecov-io commented on issue #3583: Add segment selector for merged segments URL: https://github.com/apache/incubator-pinot/pull/3583#issuecomment-443993610 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3583?src=pr&el=h1) Report > Merging [#3583](https://codecov.io/gh/apache/incubator-pinot/pull/3583?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/15ff8d8bf24d40edda3a82d3091586ccdb1e591c?src=pr&el=desc) will **increase** coverage by `0.11%`. > The diff coverage is `69.09%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/3583?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #3583 +/- ## ============================================ + Coverage 70.86% 70.98% +0.11% Complexity 4 4 ============================================ Files 1007 1009 +2 Lines 46137 46185 +48 Branches 6184 6195 +11 ============================================ + Hits 32696 32784 +88 + Misses 11295 11251 -44 - Partials 2146 2150 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3583?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...roker/routing/builder/BaseRoutingTableBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/3583/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9yb3V0aW5nL2J1aWxkZXIvQmFzZVJvdXRpbmdUYWJsZUJ1aWxkZXIuamF2YQ==) | `95.58% <0%> (-2.9%)` | `0 <0> (ø)` | | | [...builder/BasePartitionAwareRoutingTableBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/3583/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9yb3V0aW5nL2J1aWxkZXIvQmFzZVBhcnRpdGlvbkF3YXJlUm91dGluZ1RhYmxlQnVpbGRlci5qYXZh) | `75.67% <0%> (-4.33%)` | `0 <0> (ø)` | | | [...roker/routing/selector/SegmentSelectorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/3583/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9yb3V0aW5nL3NlbGVjdG9yL1NlZ21lbnRTZWxlY3RvckZhY3RvcnkuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | | | [...ing/builder/DefaultOfflineRoutingTableBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/3583/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9yb3V0aW5nL2J1aWxkZXIvRGVmYXVsdE9mZmxpbmVSb3V0aW5nVGFibGVCdWlsZGVyLmphdmE=) | `47.05% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../broker/routing/HelixExternalViewBasedRouting.java](https://codecov.io/gh/apache/incubator-pinot/pull/3583/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9yb3V0aW5nL0hlbGl4RXh0ZXJuYWxWaWV3QmFzZWRSb3V0aW5nLmphdmE=) | `89.03% <50%> (-1.37%)` | `0 <0> (ø)` | | | [...ng/builder/DefaultRealtimeRoutingTableBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/3583/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9yb3V0aW5nL2J1aWxkZXIvRGVmYXVsdFJlYWx0aW1lUm91dGluZ1RhYmxlQnVpbGRlci5qYXZh) | `61.9% <50%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...broker/routing/selector/MergedSegmentSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/3583/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9yb3V0aW5nL3NlbGVjdG9yL01lcmdlZFNlZ21lbnRTZWxlY3Rvci5qYXZh) | `81.25% <81.25%> (ø)` | `0 <0> (?)` | | | [...lix/EmptyBrokerOnlineOfflineStateModelFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/3583/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L0VtcHR5QnJva2VyT25saW5lT2ZmbGluZVN0YXRlTW9kZWxGYWN0b3J5LmphdmE=) | `86.66% <0%> (-13.34%)` | `0% <0%> (ø)` | | | [...e/operator/dociditerators/MVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3583/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2RvY2lkaXRlcmF0b3JzL01WU2NhbkRvY0lkSXRlcmF0b3IuamF2YQ==) | `48.48% <0%> (-12.13%)` | `0% <0%> (ø)` | | | [...mpl/dictionary/DoubleOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3583/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Eb3VibGVPZmZIZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `72.72% <0%> (-10.91%)` | `0% <0%> (ø)` | | | ... and [28 more](https://codecov.io/gh/apache/incubator-pinot/pull/3583/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3583?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3583?src=pr&el=footer). Last update [15ff8d8...adb3ade](https://codecov.io/gh/apache/incubator-pinot/pull/3583?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
