mayankshriv commented on a change in pull request #3583: Add segment selector
for merged segments
URL: https://github.com/apache/incubator-pinot/pull/3583#discussion_r238776160
##########
File path:
pinot-broker/src/main/java/com/linkedin/pinot/broker/routing/builder/DefaultRealtimeRoutingTableBuilder.java
##########
@@ -68,7 +69,7 @@ public void computeOnExternalViewChange(String tableName,
ExternalView externalV
}
@Override
- public Map<String, List<String>> getRoutingTable(RoutingTableLookupRequest
request) {
+ public Map<String, List<String>> getRoutingTable(RoutingTableLookupRequest
request, SegmentSelector segmentSelector) {
Review comment:
Should selector be passed into this api, or should it belong inside of the
builder(s)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
