codecov-io commented on issue #3505: Handle invalid durations in the duration DSL URL: https://github.com/apache/incubator-pinot/pull/3505#issuecomment-444277995 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3505?src=pr&el=h1) Report > Merging [#3505](https://codecov.io/gh/apache/incubator-pinot/pull/3505?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/e2916ed5aed7430d781a8aa602f995e24ffdb6e0?src=pr&el=desc) will **increase** coverage by `11.67%`. > The diff coverage is `54.54%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/3505?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #3505 +/- ## ============================================= + Coverage 59.08% 70.76% +11.67% Complexity 4 4 ============================================= Files 1155 1007 -148 Lines 58552 46179 -12373 Branches 8109 6193 -1916 ============================================= - Hits 34596 32678 -1918 + Misses 21559 11346 -10213 + Partials 2397 2155 -242 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3505?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../com/linkedin/pinot/common/config/DurationDsl.java](https://codecov.io/gh/apache/incubator-pinot/pull/3505/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2NvbW1vbi9jb25maWcvRHVyYXRpb25Ec2wuamF2YQ==) | `50% <54.54%> (-25%)` | `0 <0> (ø)` | | | [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3505/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2RhdGEvbWFuYWdlci9yZWFsdGltZS9SZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `75% <0%> (-25%)` | `0% <0%> (ø)` | | | [...pinot/core/operator/docidsets/OrBlockDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/3505/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2RvY2lkc2V0cy9PckJsb2NrRG9jSWRTZXQuamF2YQ==) | `84.9% <0%> (-13.21%)` | `0% <0%> (ø)` | | | [.../BrokerResourceOnlineOfflineStateModelFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/3505/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9icm9rZXIvaGVsaXgvQnJva2VyUmVzb3VyY2VPbmxpbmVPZmZsaW5lU3RhdGVNb2RlbEZhY3RvcnkuamF2YQ==) | `49.15% <0%> (-10.17%)` | `0% <0%> (ø)` | | | [...ore/query/scheduler/resources/ResourceManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3505/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L3NjaGVkdWxlci9yZXNvdXJjZXMvUmVzb3VyY2VNYW5hZ2VyLmphdmE=) | `87.09% <0%> (-9.68%)` | `0% <0%> (ø)` | | | [...pinot/controller/validation/ValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3505/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL3ZhbGlkYXRpb24vVmFsaWRhdGlvbk1hbmFnZXIuamF2YQ==) | `59.28% <0%> (-7.15%)` | `0% <0%> (ø)` | | | [...impl/dictionary/DoubleOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3505/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Eb3VibGVPbkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `68.88% <0%> (-6.67%)` | `0% <0%> (ø)` | | | [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3505/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9GbG9hdE9uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `86.66% <0%> (-6.67%)` | `0% <0%> (ø)` | | | [...impl/dictionary/FloatOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3505/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9GbG9hdE9mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `87.27% <0%> (-5.46%)` | `0% <0%> (ø)` | | | [...e/operator/dociditerators/SortedDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3505/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2RvY2lkaXRlcmF0b3JzL1NvcnRlZERvY0lkSXRlcmF0b3IuamF2YQ==) | `54.05% <0%> (-5.41%)` | `0% <0%> (ø)` | | | ... and [162 more](https://codecov.io/gh/apache/incubator-pinot/pull/3505/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3505?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3505?src=pr&el=footer). Last update [e2916ed...de218b2](https://codecov.io/gh/apache/incubator-pinot/pull/3505?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
