codecov-io commented on issue #3589: [PINOT-7461] Fix segment deletion when folder under Deleted_Segment location does not exist URL: https://github.com/apache/incubator-pinot/pull/3589#issuecomment-445120112 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3589?src=pr&el=h1) Report > Merging [#3589](https://codecov.io/gh/apache/incubator-pinot/pull/3589?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/555ba8f6dfa008bfa965d2e1489bd2abce333551?src=pr&el=desc) will **increase** coverage by `0.07%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/3589?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #3589 +/- ## ============================================ + Coverage 70.63% 70.71% +0.07% Complexity 4 4 ============================================ Files 1009 1009 Lines 46254 46255 +1 Branches 6209 6209 ============================================ + Hits 32672 32707 +35 + Misses 11427 11405 -22 + Partials 2155 2143 -12 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3589?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...va/com/linkedin/pinot/filesystem/LocalPinotFS.java](https://codecov.io/gh/apache/incubator-pinot/pull/3589/diff?src=pr&el=tree#diff-cGlub3QtZmlsZXN5c3RlbS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9maWxlc3lzdGVtL0xvY2FsUGlub3RGUy5qYXZh) | `87.5% <100%> (+0.19%)` | `0 <0> (ø)` | :arrow_down: | | [...in/pinot/core/query/pruner/ValidSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/3589/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L3BydW5lci9WYWxpZFNlZ21lbnRQcnVuZXIuamF2YQ==) | `57.14% <0%> (-28.58%)` | `0% <0%> (ø)` | | | [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3589/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2RhdGEvbWFuYWdlci9yZWFsdGltZS9SZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `50% <0%> (-25%)` | `0% <0%> (ø)` | | | [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3589/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9GbG9hdE9uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `86.66% <0%> (-6.67%)` | `0% <0%> (ø)` | | | [...elix/core/relocation/RealtimeSegmentRelocator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3589/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcmVsb2NhdGlvbi9SZWFsdGltZVNlZ21lbnRSZWxvY2F0b3IuamF2YQ==) | `68.75% <0%> (-5.21%)` | `0% <0%> (ø)` | | | [...troller/helix/core/retention/RetentionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3589/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcmV0ZW50aW9uL1JldGVudGlvbk1hbmFnZXIuamF2YQ==) | `73.07% <0%> (-3.85%)` | `0% <0%> (ø)` | | | [...impl/dictionary/FloatOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3589/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9GbG9hdE9mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `87.27% <0%> (-1.82%)` | `0% <0%> (ø)` | | | [...rEqualitiesToInClauseFilterQueryTreeOptimizer.java](https://codecov.io/gh/apache/incubator-pinot/pull/3589/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9yZXF1ZXN0aGFuZGxlci9NdWx0aXBsZU9yRXF1YWxpdGllc1RvSW5DbGF1c2VGaWx0ZXJRdWVyeVRyZWVPcHRpbWl6ZXIuamF2YQ==) | `93.33% <0%> (-1.34%)` | `0% <0%> (ø)` | | | [.../controller/helix/core/SegmentDeletionManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3589/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvU2VnbWVudERlbGV0aW9uTWFuYWdlci5qYXZh) | `79.33% <0%> (-0.83%)` | `0% <0%> (ø)` | | | [...com/linkedin/pinot/core/common/DataBlockCache.java](https://codecov.io/gh/apache/incubator-pinot/pull/3589/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2NvbW1vbi9EYXRhQmxvY2tDYWNoZS5qYXZh) | `78.62% <0%> (-0.77%)` | `0% <0%> (ø)` | | | ... and [21 more](https://codecov.io/gh/apache/incubator-pinot/pull/3589/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3589?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3589?src=pr&el=footer). Last update [555ba8f...a2442fe](https://codecov.io/gh/apache/incubator-pinot/pull/3589?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
