npawar opened a new pull request #3591: Add stop method in PinotLLCRealtimeSegmentManager URL: https://github.com/apache/incubator-pinot/pull/3591 Commit segment metadata happens in 3 zk updates 1) consuming segment metadata update 2) new segment metadata creation 3) ideal state update. If the controller shuts down after 1 and before 3, we will end up in a state where the partition will not consume. The validation manager will fix this when it runs (currently runs every 1 hour), but this delay might not be acceptable for certain scenarios. Adding a stop method to the PinotLLCRealtimeSegmentManager, which will wait 30 seconds before stopping. This time will allow any segment metadata commits which were in progress, to complete. We will also prevent any new segment metadata commits once the shutdown has been invoked.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
