mcvsubbu commented on issue #3593: Allow completing segments to finish before stopping LLC Segment Manager URL: https://github.com/apache/incubator-pinot/pull/3593#issuecomment-445423628 > Looks like @npawar also attempted to fix this in #3591 :) > > > Occurred to me that if we start ValidationManager soon after a leadership gain, we don't need to do this PR? > > I guess if the previous leader is not "dead" it could continue running validation-mgr - unless there is a periodic isLeader() check that lets the old controller give up. Yes, @npawar and I talked about it. We need to make sure that we check the leadership before every new table we process. If we are not leader, stop the validationmanager right away.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
