snleee commented on a change in pull request #3602: Cleanup: update code to return only physical columns for select * queries URL: https://github.com/apache/incubator-pinot/pull/3602#discussion_r240438533
########## File path: pinot-core/src/main/java/com/linkedin/pinot/core/segment/virtualcolumn/BaseVirtualColumnProvider.java ########## @@ -15,13 +15,26 @@ */ package com.linkedin.pinot.core.segment.virtualcolumn; +import com.linkedin.pinot.common.data.FieldSpec; Review comment: Are we using `FieldSpec` in this class? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
