npawar commented on a change in pull request #3604: Add
ControllerLeadershipManager as single place to check controller leadership
changes
URL: https://github.com/apache/incubator-pinot/pull/3604#discussion_r240730158
##########
File path:
pinot-controller/src/main/java/com/linkedin/pinot/controller/ControllerStarter.java
##########
@@ -161,13 +161,15 @@ public void start() {
_helixResourceManager.start();
final HelixManager helixManager =
_helixResourceManager.getHelixZkManager();
+ LOGGER.info("Creating ControllerLeadershipManager instance");
+ ControllerLeadershipManager.createInstance(helixManager);
Review comment:
I put it at this place because helixManager is initialized in
pinotHelixResourceManager.start(). If we were to move it before the start, we
would have to extract out the helixManager setup part
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
