mcvsubbu commented on a change in pull request #3606: [PINOT-7476] Add metrics
to track cases where segment refresh/reloads fail
URL: https://github.com/apache/incubator-pinot/pull/3606#discussion_r240788169
##########
File path:
pinot-server/src/main/java/com/linkedin/pinot/server/starter/helix/SegmentMessageHandlerFactory.java
##########
@@ -146,6 +160,8 @@ public HelixTaskResult handleMessage() throws
InterruptedException {
try {
if (_segmentName.equals("")) {
acquireSema("ALL", _logger);
+ // NOTE: the method aborts if any segment reload encounters an
unhandled exception - can lead to inconsisten
Review comment:
nit: typo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
