codecov-io commented on issue #3607: Filter out virtual-columns in realtime segment conversion path URL: https://github.com/apache/incubator-pinot/pull/3607#issuecomment-446385853 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3607?src=pr&el=h1) Report > Merging [#3607](https://codecov.io/gh/apache/incubator-pinot/pull/3607?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/569022ad64960561a32b401f7ec1b2e6f0d6dc69?src=pr&el=desc) will **decrease** coverage by `0.04%`. > The diff coverage is `94.11%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/3607?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #3607 +/- ## =========================================== - Coverage 70.65% 70.6% -0.05% Complexity 4 4 =========================================== Files 1009 1009 Lines 46291 46293 +2 Branches 6208 6210 +2 =========================================== - Hits 32705 32685 -20 - Misses 11432 11446 +14 - Partials 2154 2162 +8 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3607?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...indexsegment/immutable/ImmutableSegmentLoader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3607/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2luZGV4c2VnbWVudC9pbW11dGFibGUvSW1tdXRhYmxlU2VnbWVudExvYWRlci5qYXZh) | `92.15% <100%> (-0.16%)` | `0 <0> (ø)` | | | [...e/realtime/converter/RealtimeSegmentConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3607/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2NvbnZlcnRlci9SZWFsdGltZVNlZ21lbnRDb252ZXJ0ZXIuamF2YQ==) | `75.71% <93.33%> (+2.57%)` | `0 <0> (ø)` | :arrow_down: | | [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3607/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2RhdGEvbWFuYWdlci9yZWFsdGltZS9SZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh) | `50% <0%> (-50%)` | `0% <0%> (ø)` | | | [...egation/function/customobject/MinMaxRangePair.java](https://codecov.io/gh/apache/incubator-pinot/pull/3607/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L2FnZ3JlZ2F0aW9uL2Z1bmN0aW9uL2N1c3RvbW9iamVjdC9NaW5NYXhSYW5nZVBhaXIuamF2YQ==) | `75.86% <0%> (-24.14%)` | `0% <0%> (ø)` | | | [...e/operator/dociditerators/MVScanDocIdIterator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3607/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2RvY2lkaXRlcmF0b3JzL01WU2NhbkRvY0lkSXRlcmF0b3IuamF2YQ==) | `45.45% <0%> (-21.22%)` | `0% <0%> (ø)` | | | [.../impl/dictionary/FloatOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3607/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9GbG9hdE9uSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `80% <0%> (-13.34%)` | `0% <0%> (ø)` | | | [...pinot/core/operator/docidsets/OrBlockDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/3607/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2RvY2lkc2V0cy9PckJsb2NrRG9jSWRTZXQuamF2YQ==) | `84.9% <0%> (-13.21%)` | `0% <0%> (ø)` | | | [...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3607/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Mb25nT25IZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `88.88% <0%> (-6.67%)` | `0% <0%> (ø)` | | | [...impl/dictionary/FloatOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3607/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9GbG9hdE9mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `81.81% <0%> (-5.46%)` | `0% <0%> (ø)` | | | [.../impl/dictionary/BaseOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3607/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9CYXNlT2ZmSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `81.03% <0%> (-2.88%)` | `0% <0%> (ø)` | | | ... and [18 more](https://codecov.io/gh/apache/incubator-pinot/pull/3607/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3607?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3607?src=pr&el=footer). Last update [569022a...a2227ce](https://codecov.io/gh/apache/incubator-pinot/pull/3607?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
