sunithabeeram commented on a change in pull request #3614: Adding a class to get statistics about a request (query) processed by… URL: https://github.com/apache/incubator-pinot/pull/3614#discussion_r241271124
########## File path: pinot-broker/src/main/java/com/linkedin/pinot/broker/api/RequestStatistics.java ########## @@ -0,0 +1,171 @@ +/** + * Copyright (C) 2014-2015 LinkedIn Corp. ([email protected]) + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.linkedin.pinot.broker.api; + +import com.linkedin.pinot.common.request.BrokerRequest; +import com.linkedin.pinot.common.request.QueryType; +import com.linkedin.pinot.common.response.BrokerResponse; + + +/** + * A class to hold the details regarding a request and the statistics. + * This object can be used to publish the query processing statistics to a stream for + * post-processing at a finer level than metrics. + */ +public class RequestStatistics { Review comment: What might be the limits of the data that can be pushed through this? There are other tidbits of info that I would like to see in here, so would be good to know what the limits (if any) are; for ex, the brokerProcessingTime (current processingtime includes server+broker latency); it would be good to include the server-stats that are normally logged, and perhaps some client side info as well. In anycase, it will be good if this is easily extensible. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
