mcvsubbu commented on a change in pull request #3614: Adding a class to get statistics about a request (query) processed by… URL: https://github.com/apache/incubator-pinot/pull/3614#discussion_r241494582
########## File path: pinot-broker/src/main/java/com/linkedin/pinot/broker/api/RequestStatistics.java ########## @@ -0,0 +1,171 @@ +/** + * Copyright (C) 2014-2015 LinkedIn Corp. ([email protected]) + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package com.linkedin.pinot.broker.api; + +import com.linkedin.pinot.common.request.BrokerRequest; +import com.linkedin.pinot.common.request.QueryType; +import com.linkedin.pinot.common.response.BrokerResponse; + + +/** + * A class to hold the details regarding a request and the statistics. + * This object can be used to publish the query processing statistics to a stream for + * post-processing at a finer level than metrics. + */ +public class RequestStatistics { Review comment: The limits are not defined here, so we can always add more stuff to this object. Limitations will be (if any) on the streams channel in which events are published. The events will contain data out of this object. The limitation will be defined by the schema chosen for publishing. The schema may or many not include all members of RequestStatistics. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
