codecov-io edited a comment on issue #3607: Filter out virtual-columns in realtime segment conversion path URL: https://github.com/apache/incubator-pinot/pull/3607#issuecomment-446385853 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3607?src=pr&el=h1) Report > Merging [#3607](https://codecov.io/gh/apache/incubator-pinot/pull/3607?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/569022ad64960561a32b401f7ec1b2e6f0d6dc69?src=pr&el=desc) will **increase** coverage by `0.17%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/3607?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #3607 +/- ## ============================================ + Coverage 70.65% 70.82% +0.17% Complexity 4 4 ============================================ Files 1009 1011 +2 Lines 46291 46413 +122 Branches 6208 6212 +4 ============================================ + Hits 32705 32874 +169 + Misses 11432 11374 -58 - Partials 2154 2165 +11 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3607?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../controller/helix/ControllerRequestURLBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/3607/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L0NvbnRyb2xsZXJSZXF1ZXN0VVJMQnVpbGRlci5qYXZh) | `74.19% <100%> (+0.86%)` | `0 <0> (ø)` | :arrow_down: | | [...e/realtime/converter/RealtimeSegmentConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/3607/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2NvbnZlcnRlci9SZWFsdGltZVNlZ21lbnRDb252ZXJ0ZXIuamF2YQ==) | `75.75% <100%> (+2.62%)` | `0 <0> (ø)` | :arrow_down: | | [...in/java/com/linkedin/pinot/common/data/Schema.java](https://codecov.io/gh/apache/incubator-pinot/pull/3607/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2NvbW1vbi9kYXRhL1NjaGVtYS5qYXZh) | `81.14% <100%> (+0.59%)` | `0 <0> (ø)` | :arrow_down: | | [...indexsegment/immutable/ImmutableSegmentLoader.java](https://codecov.io/gh/apache/incubator-pinot/pull/3607/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL2luZGV4c2VnbWVudC9pbW11dGFibGUvSW1tdXRhYmxlU2VnbWVudExvYWRlci5qYXZh) | `92.15% <100%> (-0.16%)` | `0 <0> (ø)` | | | [...loader/defaultcolumn/BaseDefaultColumnHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3607/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3NlZ21lbnQvaW5kZXgvbG9hZGVyL2RlZmF1bHRjb2x1bW4vQmFzZURlZmF1bHRDb2x1bW5IYW5kbGVyLmphdmE=) | `92% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...x/loader/defaultcolumn/V3DefaultColumnHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/3607/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3NlZ21lbnQvaW5kZXgvbG9hZGVyL2RlZmF1bHRjb2x1bW4vVjNEZWZhdWx0Q29sdW1uSGFuZGxlci5qYXZh) | `22.22% <0%> (-55.56%)` | `0% <0%> (ø)` | | | [...egation/function/customobject/MinMaxRangePair.java](https://codecov.io/gh/apache/incubator-pinot/pull/3607/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3F1ZXJ5L2FnZ3JlZ2F0aW9uL2Z1bmN0aW9uL2N1c3RvbW9iamVjdC9NaW5NYXhSYW5nZVBhaXIuamF2YQ==) | `75.86% <0%> (-24.14%)` | `0% <0%> (ø)` | | | [...pinot/core/operator/docidsets/OrBlockDocIdSet.java](https://codecov.io/gh/apache/incubator-pinot/pull/3607/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL29wZXJhdG9yL2RvY2lkc2V0cy9PckJsb2NrRG9jSWRTZXQuamF2YQ==) | `84.9% <0%> (-13.21%)` | `0% <0%> (ø)` | | | [...impl/dictionary/FloatOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3607/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9GbG9hdE9mZkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `78.18% <0%> (-9.1%)` | `0% <0%> (ø)` | | | [...e/impl/dictionary/LongOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3607/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Mb25nT25IZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `88.88% <0%> (-6.67%)` | `0% <0%> (ø)` | | | ... and [40 more](https://codecov.io/gh/apache/incubator-pinot/pull/3607/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3607?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3607?src=pr&el=footer). Last update [569022a...aa4dd1c](https://codecov.io/gh/apache/incubator-pinot/pull/3607?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
